Repository navigation
build: generic Docker image published by CI; MOLARS types from molars_lcmtypes - #20
Merged
Merged
Conversation
- The Dial proxy no longer imports senlcm/stdlcm. It resolves the image type by LCM name (--image-type, default senlcm.image_t) from the discovered packages, so it works with prefixed packages such as compas_lcmtypes or with unprefixed lcm-gen output. - Both proxies accept --lcm-packages. The Dial proxy defaults to compas_lcmtypes,molars_lcmtypes; the JSON proxy keeps its positional argument for compatibility. - New 'lcmtypes' extra installs compas-lcmtypes (PyPI) and molars-lcmtypes (CoMPASLab/molars_lcmtypes GitHub release). - Configuration errors (no types found, unknown image type, failed workers) now exit non-zero. - Tests and benchmarks use compas-lcmtypes instead of the vendored MOLARS copies, which are removed; benchmarks no longer need PYTHONPATH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- A single image serves both proxies (PROXY=json|dial), replacing Dockerfile.dial and the -dial tags. It bundles compas-lcmtypes and molars-lcmtypes, so no MOLARS wheel needs to be copied into the repo. - Installs from uv.lock (uv sync --locked) into a venv copied onto a slim Python base; libglib comes from the distro package instead of a copied x86_64 .so. - New entrypoint configures the proxy from HOST, PORT, CHANNEL, LCM_PACKAGES and ARGS; extra flags may also be passed as arguments, and other commands run as given. - docker-bake.hcl is the shared build definition for CI and local builds; docker/smoke_test.sh checks both proxies become healthy. - Removes the docker_* shell scripts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Run semantic-release publish so GitHub releases get the wheel and sdist (version alone does not upload them). - Expose released/version/prerelease from the release job. - New docker job: on pull requests the image is built and smoke-tested; after a release it is built from the release tag, smoke-tested and pushed to Docker Hub as X.Y.Z, X.Y and latest (main) or X.Y.Z-rc.N and develop (develop). Requires DOCKERHUB_USERNAME and DOCKERHUB_TOKEN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the manual, MOLARS-coupled Docker build with one generic image built, smoke-tested and published by CI after each release. Also fixes the missing GitHub release assets.
The MOLARS LCM types now live in the new public repo CoMPASLab/molars_lcmtypes:
main(40170cb) with history preserved, and is released as v0.1.0.compas_lcmtypes: the types install undermolars_lcmtypes.*and referencecompas_lcmtypes.*.This repo now depends on the types instead of copying a MOLARS wheel into the build context.
Changes
--image-type, defaultsenlcm.image_t) among the discovered packages, so it works with prefixed and unprefixed types.--lcm-packages; the Dial proxy defaults tocompas_lcmtypes,molars_lcmtypes.lcmtypesextra: installscompas-lcmtypes(PyPI) andmolars-lcmtypes(GitHub release wheel), locked inuv.lock. Tests usecompas-lcmtypesinstead of vendored copies, and benchmarks no longer needPYTHONPATH.mbari/lcm-websocket-server:PROXY=json|dialselects the proxy, configured viaHOST,PORT,CHANNEL,LCM_PACKAGESandARGS.uv.lock(uv sync --locked) and includes all extras and types..so.docker-bake.hclis the shared build definition anddocker/smoke_test.shchecks both proxies become healthy.Dockerfile.dial, the-dialtags and the fivescripts/docker_*.share removed.semantic-release publish, so GitHub releases get the wheel and sdist.v0.9.0-rc.1was missing them.dockerjob: on PRs it builds and smoke-tests the image. After a release it builds from the release tag, smoke-tests, and pushesX.Y.Z,X.Yandlatest(frommain) orX.Y.Z-rc.Nanddevelop(fromdevelop).GITHUB_TOKENdon't trigger other workflows.Behavior changes
-dialimage tags. Use-e PROXY=dial.JPEG_QUALITY/JPEG_SCALEare replaced byARGS="--quality .. --scale ..".LCM_PACKAGESnow defaults tocompas_lcmtypes,molars_lcmtypesinstead of being required.stdlcm,senlcm, ...) to the prefixed packages. Existing installs of the old MOLARS wheel can keep working with--lcm-packages stdlcm,senlcm,....Before merging
Add the Docker Hub secrets, or the first post-release
dockerjob will fail at login:Test plan
uv run pytest: 179 passed, including Dial and JSON CLI end-to-end tests and exit codes for configuration errorsdocker buildx bakeanddocker/smoke_test.sh: both proxies healthy; entrypoint pass-through, flag appending, badPROXY(exit 2) and bad--image-type(exit 1) checkedPYTHONPATH); results unchangeddockersmoke testdeveloppushes0.9.0-rc.2anddevelopto Docker Hub🤖 Generated with Claude Code